• scottmg's avatar
    Enable incremental linking for static_library too · 6922bc1d
    scottmg authored
    Timings on z620:
    
    Without:
    
    GYP_DEFINES=component=static_library chromium_win_pch=0 incremental_chrome_dll=0
    
    touch content\app\main.cc (causes chrome.dll, chrome_child.dll, and unit_tests.exe to relink)
    tim ninja -C out\Release unit_tests
    [19/19] LINK_EMBED unit_tests.exe
    
    real: 4m46.828s
    
    With:
    
    GYP_DEFINES=component=static_library branding=Chrome chromium_win_pch=0 incremental_chrome_dll=1
    
    touch content\app\content_main.cc && tim ninja -C out\Release unit_tests
    ninja: Entering directory `out\Release'
    [19/19] LINK_EMBED unit_tests.exe
    
    real: 0m43.625s
    
    This is basically best case, and the actual performance on bots will differ based on
    their config and the number of files that change from run-to-run, but it seems worth
    enabling to see what happens, at least.
    
    R=jam@chromium.org
    BUG=404809,402270
    
    Review URL: https://codereview.chromium.org/502993005
    
    Cr-Commit-Position: refs/heads/master@{#295786}
    6922bc1d
chrome_dll.gypi 14.1 KB