GitLab

The use of WaitForGetFavicon() is unnecessary and misleading because
it introduces a nested runloop where many things can happen, including
model changes that call
BookmarksMatchVerifierChecker::IsExitConditionSatisfied() and hence
make it reentrant.

It is unnecessary because, starting with
55b3fe20, a loading favicon is
guaranteed to ultimately notify a model change, which will trigger
MultiClientStatusChangeChecker::OnStateChanged() and hence
IsExitConditionSatisfied().

Bug: 783774
Change-Id: I02c7623e3bb173b25b9c715b7bdf9c646300e3ee
Reviewed-on: https://chromium-review.googlesource.com/785091
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522089}