• Eugene But's avatar
    Use -userIsInteracting for user gesture detection if voice over is off. · 6943fdf8
    Eugene But authored
    Notable changes:
     - updated testLinkWithBlankTargetWithoutUserGesture to execute script
       without user gesture
     - removed NavigationActionInitiationType::kScriptInitiated because there
       is no way to tell if action was initiated by the script (coordinates or
       SyntheticClickType can be 0 for valid link clicks).
     - Updated webView:createWebViewWithConfiguration: to use
       GetNavigationActionInitiationTypeWithVoiceOverOn, because there is no
       need to inspect action.description when Voice over is Off.
       -userIsInteracting can give false positives for link clicks, which is
       ok. window.open also have these false positives, so if the page wants
       to open a popup, it can exploit window.open.
    
    Bug: 849749
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: I8c179c9df2d6bce3253e46272c2f14e0eb6224bc
    Reviewed-on: https://chromium-review.googlesource.com/1087389
    Commit-Queue: Eugene But <eugenebut@chromium.org>
    Reviewed-by: default avatarMohammad Refaat <mrefaat@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#565442}
    6943fdf8
crw_web_controller.mm 229 KB