• dtseng@chromium.org's avatar
    Support global keyboard commands on Chrome OS. · 698b41f9
    dtseng@chromium.org authored
    Currently, AcceleratorController delivers accelerators to GlobalCommandsListenerChromeOS (which is an AcceleratorTarget). We respect the same conditions found within AcceleratorController to disallow shortcuts in specific instances (e.g. login screen locked screen, empty windows). AcceleratorController is owned by the ash::Shell and knows about existing keyboard shortcuts/actions.
    
    BUG=336761
    TEST=interactive_ui_tests --gtest_filter=GlobalCommandsApiTest.*
    
    And, manually, on a desktop build of Chrome with GYP_DEFINES=chromeos=1...
    
    with a component extension:
    
    Verified that
    - a global shortcut (ctrl+shift+0) works with focus in
    1. web content
    2. shelf
    3. toolbars (omni box, View(s)).
    
    Verified that processing does not occur in the following cases (similarly to most other ash accelerators) as expected:
    - OOBE
    - locked screen
    - desktop with no windows open
    - sign in screen (after logging out).
    
    Review URL: https://codereview.chromium.org/350943003
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282110 0039d316-1c4b-4281-b951-d872f2087c98
    698b41f9
command.cc 18.9 KB