• Charlie Andrews's avatar
    Add Nexus 5X disables for all tests disabled on Nexus 5 · 69b8ea5c
    Charlie Andrews authored
    This is necessary in order to fix http://crbug.com/894906, where all
    tests disabled on Nexus 5 were accidentally disabled on Nexus 5X
    "Nexus 5X" contains the string "Nexus 5", and we were targeting the
    disables based on substring matching.
    
    I erred on the side of being redundant: if there was both a "Nexus 5"
    disable and an "Android" disable, I added a corresponding "Nexus 5X"
    disable. My idea here was that, if at some later point the "All" bug
    got fixed and the test got reenabled, I didn't want the person doing
    that to be confused why the story was failing on Nexus 5X still.
    Associating the logic bug with the disable explicitly reduces that
    confusion.
    
    Bug: 894906
    Change-Id: I601304a979c7b7c6451d1571f8ffce61a60f4ecd
    Reviewed-on: https://chromium-review.googlesource.com/c/1355482Reviewed-by: default avatarNed Nguyen <nednguyen@google.com>
    Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
    Commit-Queue: Charlie Andrews <charliea@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#612294}
    69b8ea5c
expectations.config 28.1 KB