• gunsch's avatar
    Removes MediaDecoderJob virtual method call from destructor. · 6a1f7b51
    gunsch authored
    This execution path is currently seen used when destroying a
    VideoDecoderJob that's still decoding:
    * MediaDecoderJob::Release (early return, destroy_pending_=true)
    * ...
    * MediaDecoderJob::OnDecodeComplete
    * ~VideoDecoderJob
    * ~MediaDecoderJob
    * MediaDecoderJob::ReleaseMediaCodecBridge
    * MediaDecoderJob::OnMediaCodecBridgeReleased <-- !!!
    
    The last line should be:
    * VideoDecoderJob::OnMediaCodecBridgeReleased
    
    but since it is invoked during the destructor the overridden
    implementation is not executed.
    
    R=qinmin@chromium.org,xhwang@chromium.org
    BUG=internal b/17671489
    
    Review URL: https://codereview.chromium.org/647553003
    
    Cr-Commit-Position: refs/heads/master@{#299159}
    6a1f7b51
media_decoder_job.cc 21.4 KB