• Chris Davis (EDGE)'s avatar
    Reland "Add dbghelp.dll to delay load list" · 6a60c787
    Chris Davis (EDGE) authored
    This is a reland of 4edc0503. With
    the fix in clang for the delay load crash previously hit with this
    change I am relanding this.
    
    Bug: 1132179
    
    Original change's description:
    > Add dbghelp.dll to delay load list
    >
    > Currently, many of the binaries have a static dependency on dbghelp.dll.
    > This results in dbghelp getting loaded in all chrome processes. Upon
    > inspection, dbghelp.dll is only necessary for stack sampling and mini
    > dump handing in crashpad. Stack sampling is only enabled by default on
    > unofficial builds of dev and canary.  All other times we are needlessly
    > loading this module which brings in 300k of image file refset and 60k
    > of Copy on Write costs per process.  This change adds it to the delay
    > load list.
    >
    > Change-Id: I13da0ce0735431c5c51cdbc9ba2cfea0cc3cded7
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336541
    > Commit-Queue: Chris Davis <chrdavis@microsoft.com>
    > Reviewed-by: Cliff Smolinsky <cliffsmo@microsoft.com>
    > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
    > Reviewed-by: Nico Weber <thakis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#796707}
    
    Change-Id: I5f946d76af853c2d277f670b99479e874e784f44
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523245Reviewed-by: default avatarNico Weber <thakis@chromium.org>
    Reviewed-by: default avatarCliff Smolinsky <cliffsmo@microsoft.com>
    Commit-Queue: Chris Davis <chrdavis@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#832526}
    6a60c787
delayloads_unittest.cc 12.7 KB