• Clark DuVall's avatar
    Reland "Reland "Convert tcp_device_provider.cc to mojo host resolver"" · 6af9f9ee
    Clark DuVall authored
    This is a reland of 6493250f
    
    There were reports of crashes when opening devtools because of a DCHECK
    deep inside GetActiveUserProfile. This switches to using the system
    network context, as suggested by mmenke@. This also simplifies things
    quite a bit as we don't have to pass around a BrowserContext.
    
    Original change's description:
    > Reland "Convert tcp_device_provider.cc to mojo host resolver"
    >
    > This is a reland of ac880b3a
    >
    > Switched to using
    > ChromeDevToolsManagerDelegate::GetDefaultBrowserContext() which
    > outlives TCPDeviceProvider. The original was reverted because of a
    > crash when TCPDeviceProvider tried to access a destroyed
    > BrowserContext, see http://crbug.com/879060.
    >
    > Original change's description:
    > > Convert tcp_device_provider.cc to mojo host resolver
    > >
    > > Bug: 874653
    > > Change-Id: I95b968427344a4c9821c0985ae1f89c153036bcd
    > > Reviewed-on: https://chromium-review.googlesource.com/1185626
    > > Commit-Queue: Clark DuVall <cduvall@chromium.org>
    > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#586738}
    >
    > Bug: 874653
    > Change-Id: Ia6c00ba51020473f820add8c4257f3bf16fd5b24
    > Reviewed-on: https://chromium-review.googlesource.com/1197265
    > Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
    > Commit-Queue: Clark DuVall <cduvall@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#587750}
    
    Bug: 874653
    Change-Id: Ifc6eddc0d05bd65792165d5542fe98b09ff0fb05
    Reviewed-on: https://chromium-review.googlesource.com/1199848Reviewed-by: default avatarEric Orth <ericorth@chromium.org>
    Reviewed-by: default avatarAndrey Kosyakov <caseq@chromium.org>
    Commit-Queue: Clark DuVall <cduvall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#588890}
    6af9f9ee
tcp_device_provider.cc 5.75 KB