• Samuel Huang's avatar
    [DevUI DFM] Fix breakage in APK builds. · 6b7fa064
    Samuel Huang authored
    DevUI DFM is on for bundle (AAB) builds only. For APK builds, which
    does not support DFM, DevUI pages should be available by default.
    However, the |dfmify_dev_ui| flag is common for bundle and APK builds.
    So when the flag is on, for both bundle and APK builds:
    * dev_ui_resources.pak is split from resources.pak, and
    * Code to {check, perform} DevUI DFM {install, loading} are active.
    
    As a result, DevUI pages break for APK builds (used by Android K).
    Currently this only affects chrome://bluetooth-internals since that's
    the only page moved into the DevUI DFM.
    
    The fix: Include DevUI DFM Java classes and dev_ui_resources.pak into
    the APK file. The Java classes tells DFM infra stub that the DevUI
    module is installed, and the PAK provides the resources needed.
    
    Bug: 1004263
    Change-Id: I3bec6682799c49e84cf0a700c1b61a33a3335005
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807069Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
    Reviewed-by: default avatarTibor Goldschwendt <tiborg@chromium.org>
    Commit-Queue: Samuel Huang <huangs@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#696925}
    6b7fa064
chrome_public_apk_tmpl.gni 18.1 KB