GitLab

This reverts commit 94a8710d.

Reason for revert: Seems to have caused significant flakiness of many WebRtc tests: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTRhODcxMGRjZmViMjFhNDUxNjBjOTY4NmVkZWVjN2RlN2UzMjVjNAw

Original change's description:
> Reland "Support dynamic refresh of WebRtcEventLogCollectionAllowed policy"
> 
> This is a reland of 7dae0f63
> 
> The original CL caused flakiness because, in production code,
> WebRtcEventLogManager is torn down during Chrome shutdown, after
> all threads other the the UI thread have quit. For unit tests, this
> was not the case, and so the tests hit some use-after-destruction.
> This was fixed by making the tests stop the non-UI threads before
> tearing down WebRtcEventLogManager.
> 
> Original change's description:
> > Support dynamic refresh of WebRtcEventLogCollectionAllowed policy
> >
> > Add suport for dynamic refresh of WebRtcEventLogCollectionAllowed:
> > 1. If the policy was disabled before, and becomes enabled,
> >    subsequent calls to StartRemoteLogging() will succeed (barring
> >    unrelated issues), even for peer connections created while the
> >    policy was disabled.
> > 2. If the policy was enabled before, and becomes disabled:
> >    a. Peer connections associated with the profile reject
> >       calls to StartRemoteLogging().
> >    b. Active logs (associated with the profile) are stopped,
> >       and those log files deleted.
> >    c. Pending log files (associated with the profile) are deleted.
> >    d. If a log file associated with the relevant profile is
> >       currently being uploaded, the upload will be cancelled,
> >       and the file deleted.
> >
> > Bug: 775415
> > Change-Id: I70a02ff04eded2926e56fa8e368715ec1ff7c34f
> > Reviewed-on: https://chromium-review.googlesource.com/1162168
> > Reviewed-by: Guido Urdaneta <guidou@chromium.org>
> > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Commit-Queue: Elad Alon <eladalon@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581167}
> 
> TBR=guidou@chromium.org
> 
> Bug: 775415
> Change-Id: Ie6070a8843012580c9a6c069f65c01b8d63525ff
> Reviewed-on: https://chromium-review.googlesource.com/1168962
> Commit-Queue: Elad Alon <eladalon@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582162}

TBR=avi@chromium.org,pastarmovj@chromium.org,guidou@chromium.org,eladalon@chromium.org

Change-Id: I39bd5b6ac26325522f068e78846dde2443f067ec
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 775415
Reviewed-on: https://chromium-review.googlesource.com/1171263Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582261}