• Tommy C. Li's avatar
    Omnibox UI Experiments: Steady State Elisions - don't re-elide on alt-tab · 6c74cdcf
    Tommy C. Li authored
    Previously, when the user placed the cursor in the URL and unelided the
    URL, and then pressed Alt-Tab to switch windows, and then to switch
    back, the URL would be re-elided.
    
    This is not desirable. The Omnibox state should not change merely from
    switching windows. It should re-elide only if the user focuses something
    else in the same window.
    
    This CL fixes the bug and adds a test for this behavior.
    
    It also updates the test to make failure messages more clear about
    which line has the failing condition.
    
    Bug: 797354
    Change-Id: I43905e1248c439651bd6b6a66d57d46dff0989e2
    Reviewed-on: https://chromium-review.googlesource.com/1014347
    Commit-Queue: Tommy Li <tommycli@chromium.org>
    Reviewed-by: default avatarJustin Donnelly <jdonnelly@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#551158}
    6c74cdcf
omnibox_view_views.cc 47.7 KB