• vitaliii's avatar
    [unified-consent] Don't record user events when datatype is disabled. · 6c9b025b
    vitaliii authored
    USER_EVENTS is a special datatype, because it is commit-only. Therefore,
    it is handled in a special way in a processor. As a result, when the
    datatype is disabled (e.g. in Sync settings), it does not stop recording.
    This was not a problem before, because there was no user visible way to
    disable user events recording (except through history, but that works
    well), however after unified consent there will be a separate toggle
    in settings. This CL adds a temporary workaround (explicit check in the
    user event service for the datatype) for M69 and only when USER_CONSENTS
    type is enabled.
    
    Once we improve handling of commit only types (https://crbug.com/830535),
    this workaround won't be needed anymore.
    
    Bug: 860616
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
    Change-Id: Idac71d1d8d8d5a504940ffb1e09d6a7173989c57
    Reviewed-on: https://chromium-review.googlesource.com/1143475
    Commit-Queue: vitaliii <vitaliii@chromium.org>
    Reviewed-by: default avatarMarkus Heintz <markusheintz@chromium.org>
    Reviewed-by: default avatarMarc Treib <treib@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#577839}
    6c9b025b
user_event_service_impl.h 2.18 KB