• kylechar's avatar
    Improve InProcessGpuMemoryBufferManager thread safety. · 6d6affc7
    kylechar authored
    Don't pass GpuChannelManager to InProcessGpuMemoryBufferManager. Most of
    GpuChannelManager should only be accessed from the GPU thread so there
    is the potential for unsafe operations. Both SyncPointManager and
    GpuMemoryBufferFactory are thread safe so they should be fine.
    
    Also ensure that GpuMemoryBuffer destruction callbacks dereference their
    WeakPtr on the correct thread. GpuMemoryBuffers can be created and used
    on any thread, even though InProcessGpuMemoryBufferManager isn't used
    on multiple threads currently.
    
    Bug: 902163
    Change-Id: I8118def4fabd0307f0a58d403b9f9c08bc72fc6b
    Reviewed-on: https://chromium-review.googlesource.com/c/1330030
    Commit-Queue: kylechar <kylechar@chromium.org>
    Reviewed-by: default avatarSunny Sachanandani <sunnyps@chromium.org>
    Reviewed-by: default avatarAntoine Labour <piman@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607761}
    6d6affc7
pixel_test.cc 16.4 KB