• Mike Jackson's avatar
    Revert "Reland "Update axe-core to v3.3.2"" · 6d6e091a
    Mike Jackson authored
    This reverts commit b1540bd6.
    
    Reason for revert: Breaks http/tests/devtools/a11y-axe-core/basic-a11y-test.js and 5 other(s), see issue 1004150 (on Linux)
    
    Original change's description:
    > Reland "Update axe-core to v3.3.2"
    >
    > This is a reland of 0f435b65
    >
    > Original change's description:
    > > Update axe-core to v3.3.2
    > >
    > > This change updates the version of axe-core to the latest released
    > > version. As part of picking up the latest version, the following
    > > additional changes were made:
    > >
    > > 1) axe-core removed the 'href-no-hash' rule, so that been removed
    > >    from the test list.
    > >
    > > 2) Several 'link-in-text-block' tests started failing with
    > >    axe-core v3.0.2 (and later). These tests do pass in v3.0.1, but
    > >    are disabled as part of this change.
    > >      - CrManagementA11yTest.SimpleTest_link_in_text_block
    > >      - CrManagementA11yTestWithExtension.
    > >                                 ExtensionSection_link_in_text_block
    > >      - CrostiniAccessibilityTest.CROSTINI_link_in_text_block
    > >      - CrExtensionsA11yTest.NoExtensions_link_in_text_block
    > >      - MultideviceA11yTest.MULTIDEVICE_link_in_text_block
    > >      - MultideviceFeaturesA11yTest.
    > >               MULTIDEVICE_FEATURES_ACCESSIBILITY_link_in_text_block
    > >
    > > 3) One 'heading-order' test started failing in v3.0.0 (and later).
    > >    This tests does pass in V2.4.2, but is disabled as part of this
    > >    change.
    > >      - CrExtensionsA11yTestWithMultipleExensions.
    > >                                        WithExtensions_heading_order
    > >
    > > I spent some time investigating the test failures, and it looks
    > > like axe-core is highlighting legitimate product issues.
    > >
    > > Change-Id: I99c1f85087aea873e29b413dca967864fc93c786
    > > Bug: 984817
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790125
    > > Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    > > Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
    > > Commit-Queue: Mike Jackson <mjackson@microsoft.com>
    > > Cr-Commit-Position: refs/heads/master@{#695885}
    >
    > The original change caused failures in the Deterministic Linux builds.
    > This was due to devtools tests taking a dependency on axe.js, but not
    > declaring that dependency in the build.gn file. This has been fixed
    > in this change.
    >
    > Bug: 984817
    > Change-Id: I0e55bae8014654ba92afb69bb6ff8d553c018126
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800003
    > Reviewed-by: Alice Boxhall <aboxhall@chromium.org>
    > Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
    > Reviewed-by: Hector Carmona <hcarmona@chromium.org>
    > Commit-Queue: Mike Jackson <mjackson@microsoft.com>
    > Cr-Commit-Position: refs/heads/master@{#696545}
    
    TBR=aboxhall@chromium.org,pfeldman@chromium.org,hcarmona@chromium.org,luoe@chromium.org,mjackson@microsoft.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 984817, 1004150
    Change-Id: I5dc2d939ebcf338d8bd6a5ca95d41a25afc5d57f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806414
    Commit-Queue: Mike Jackson <mjackson@microsoft.com>
    Reviewed-by: default avatarYang Guo <yangguo@chromium.org>
    Reviewed-by: default avatarDominik Röttsches <drott@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#696747}
    6d6e091a
BUILD.gn 10.8 KB