• Ahmed Fakhry's avatar
    Revert "Miscellaneous holding space fixes." · 6d6f2396
    Ahmed Fakhry authored
    This reverts commit 9a224d53.
    
    Reason for revert: causing a crash of HoldingSpaceUiBrowserTest.OpenItem on linux-chromeos-chrome
    
    BUG=1133808
    
    Original change's description:
    > Miscellaneous holding space fixes.
    >
    > Fix pin toggle bounds in HoldingSpaceItemScreenshotView:
    > The bounds of the pin toggle button were being stretched to match the
    > full height of its parent container.
    >
    > Fix context menu bounds:
    > Context menu should be below the associated view (when space allows).
    >
    > Fix long press gesture:
    > When long pressing, the pressed view should become the selection just
    > prior to showing the context menu.
    >
    > Fix crash in HoldingSpaceTrayBubble:
    > If closing bubble due to ESC, bubble widget should only be closed if it
    > exists and hasn't already been marked closed.
    >
    > Fix drag behavior:
    > The holding space bubble should be closed during drag events.
    >
    > Bug: 1131262, 1131267, 1129981
    > Change-Id: I5a1f0536ae6badeed841e0a6106e9c423cbf3781
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436671
    > Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
    > Commit-Queue: David Black <dmblack@google.com>
    > Cr-Commit-Position: refs/heads/master@{#812064}
    
    TBR=dmblack@google.com,amehfooz@chromium.org
    
    Change-Id: I1a1321e8ad5a5c3dc9d7371a62908d06f4d8bdf4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 1131262
    Bug: 1131267
    Bug: 1129981
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441320Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
    Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#812272}
    6d6f2396
holding_space_tray_bubble.cc 5.9 KB