• Ken Rockot's avatar
    [mojo] Release sent handles earlier on Windows · 6dc08990
    Ken Rockot authored
    This releases HANDLE ownership *before* sending any handle in a
    message to a remote process, rather than after. Avoids an extremely
    subtle race between DuplicateHandle+DUPLICATE_CLOSE_SOURCE in the
    receiving process racing with ScopedHandle release in the sending
    process. The trade-off is the introduction of potential leaks which
    turn out to not really matter in any practical scenarios.
    
    Bug: 900655
    Change-Id: Ieec82bb062bc66cdb3c732c920a220ea2aa2f8d0
    Reviewed-on: https://chromium-review.googlesource.com/c/1310505
    Commit-Queue: Ken Rockot <rockot@google.com>
    Reviewed-by: default avatarJoe Mason <joenotcharles@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#604510}
    6dc08990
channel_win.cc 12.3 KB