• Xianzhu Wang's avatar
    Ensure update of scrollbar and caret visual rects on ancestor clip change · 6dfcf903
    Xianzhu Wang authored
    When an ancestor clip changes, we set kSubtreeVisualRectUpdate to update
    descendant visual rects which may be affected by the clip change.
    Previously we early returned in PaintInvalidator::InvalidatePaint() for
    descendants that had only kSubtreeVisualRectUpdate flag set. This caused
    other visual rects (of e.g. scrollbars, carets) that are updated during
    LayoutObject::InvalidatePaint() not updated.
    
    Now move the early return from PaintInvalidator::InvalidatePaint() into
    ObjectPaintInvalidator::ComputePaintInvalidationReason() to ensure the
    visual rects are updated.
    
    Bug: 727155
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
    Change-Id: I28f92281363c693b16121f48d21ab4f808990f14
    Reviewed-on: https://chromium-review.googlesource.com/719716
    Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
    Reviewed-by: default avatarChris Harrelson <chrishtr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#509648}
    6dfcf903
scrollbar-ancestor-clip-change-expected.txt 1.8 KB