• Shengfa Lin's avatar
    [chromedriver] Kill browser processes when timeout in py tests · 6e08fea7
    Shengfa Lin authored
    ChromeDriver python tests sometimes encounter timeout while launching
    browsers. Currently, ChromeDriver would try to re-launch browser again
    with max retry of 3 for all tests. However, the original browser might
    still be launching after the retry/retries. This change is to
    terminate/kill the original browser before the retry.
    
    There are two benefits:
    1. If the original browser is terminated/killed before retry, then
    we will not see the log from it later in ChromeDriver log.
    This can avoid confusion.
    2. It reduces resource consumption with less concurrent browsers running.
    This is in hope to reduce test flakiness.
    
    Change-Id: Ie31c155398e1c4ca19d3697e6f25f853323191ba
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586972
    Commit-Queue: Shengfa Lin <shengfa@google.com>
    Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#836800}
    6e08fea7
server.py 3.88 KB