GitLab

SplitSettingsSync leaves sync disabled until the user completes the
sync consent OOBE dialog. ExternalPrefLoader was incorrectly deciding
that sync would never enable and starting default app loading before
priority prefs are synced. This results in default apps loading too
early, potentially before the user's language is synced.

Add a pref for whether the sync consent screen is completed. If the
user hasn't completed it, observe for that pref changing, then wait
for OS priority pref sync to complete.

Bug: 1078479
Test: added to unit_tests and browser_tests
Change-Id: If633133acccfd43fe80b727b45080599ad569ceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207967Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#771277}