• Shu Chen's avatar
    Reland "[Mojo-IMF] Defines/implements mojo interface - ImeEngineClient." · 1654649e
    Shu Chen authored
    This reverts commit c9c2c4a4.
    
    Reason for revert: reland with fix.
    The root cause of the issue is that the callback passed to ProcessKeyEventDone() is released unexpectedly.
    Please see patchset diff for details.
    
    Original change's description:
    > Revert "[Mojo-IMF] Defines/implements mojo interface - ImeEngineClient."
    >
    > This reverts commit 67167003.
    >
    > Reason for revert: http://crbug.com/950211
    >
    > Original change's description:
    > > [Mojo-IMF] Defines/implements mojo interface - ImeEngineClient.
    > >
    > >  - Makes InputMethodChromeOS as an ImeEngineClient.
    > >  - Hooks up WindowTreeHostMus/WindowTreeClient to connect to ImeEngine.
    > >  - Makes calls from ImeEngine to ImeEngineClient.
    > >
    > > Bug: 937167
    > > Change-Id: I0d27ce6e9bc547f4d269cdfe0ef38e8e83673267
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1546795
    > > Commit-Queue: Shu Chen <shuchen@chromium.org>
    > > Reviewed-by: Scott Violet <sky@chromium.org>
    > > Reviewed-by: Dominick Ng <dominickn@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#648188}
    >
    > TBR=sky@chromium.org,shuchen@chromium.org,dominickn@chromium.org
    >
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    >
    > Bug: 937167
    > Change-Id: Iedc3a4e21c4236ee7a3529977fe74ba9f3a74c6b
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559846
    > Reviewed-by: Michael Wasserman <msw@chromium.org>
    > Commit-Queue: Michael Wasserman <msw@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#649171}
    
    TBR=sky@chromium.org,msw@chromium.org,shuchen@chromium.org,dominickn@chromium.org
    
    Change-Id: I91512f3ba03cd2cca122584fada92fd534537e04
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 937167
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1559415
    Commit-Queue: Shu Chen <shuchen@chromium.org>
    Reviewed-by: default avatarShu Chen <shuchen@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#649402}
    1654649e
ime.mojom 3.72 KB