• Siye Liu's avatar
    Fix a crash in JPN IME when using TSF on windows. · 6f46c031
    Siye Liu authored
    The root cause of this issue is that there is a wrong assumption in
    current TSF implementations for JPN IMEs. IMEs may start new
    composition at offset prior to current composition. We should not
    commit current composition if the start of new composition is before
    current composition. This change also fix an issue in Confirm/cancel
    composition scenario. We should notify text change for the whole buffer
    to let IME to terminate composition.
    
    Bug: 944004
    Change-Id: Iff8759481bfcb2da622483dabecfb6cc4c50da7f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1536637
    Commit-Queue: Siye Liu <siliu@microsoft.com>
    Reviewed-by: default avatarYohei Yukawa <yukawa@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#644491}
    6f46c031
tsf_text_store.cc 42.3 KB