• haraken@chromium.org's avatar
    Remove AudioNode::isMarkedForDeletion from oilpan builds · 6f506392
    haraken@chromium.org authored
    AudioNode::isMarkedForDeletion is not needed any more in oilpan builds
    for the following (non-trivial) reason:
    
    0 isMarkedForDeletion is set to true in AudioNode::dispose().
    In oilpan builds, AudioNode::dispose() is called after the AudioNode
    becomes unreachable. In other words, isMarkedForDeletion is set to true
    after the AudioNode becomes unreachable.
    
    - The only user of isMarkedForDeletion is AudioNodeInput::canUpdateState().
    AudioNodeInput::canUpdateState() returns false if isMarkedForDeletion is true.
    
    - AudioNodeInput has a strong reference to the AudioNode.
    
    These facts indicate that AudioNodeInput::canUpdateState() always returns true. Thus this CL removes the canUpdateState() checks from the code base. This also enables us to remove AudioNode::isMarkedForDeletion.
    
    BUG=340522
    NOTRY=true
    
    Review URL: https://codereview.chromium.org/458923003
    
    git-svn-id: svn://svn.chromium.org/blink/trunk@180032 bbb929c8-8fbe-4397-9dbb-9b2b20218538
    6f506392
AudioNode.cpp 19.5 KB