• Daniel Bratell's avatar
    Allow the dep cycle chrome/browser/extensions <-> api_registration · 6fec174a
    Daniel Bratell authored
    The generated api_registration files use a lot of headers
    in chrome/browser/extensions, creating a dependency cycle.
    I see no obvious way to break the cycle so this just makes
    it official.
    
    There were also a couple of files in chrome/browser/accessibility
    which were used from api registration, creating an unpleasant
    dependency. That was fixed by putting those files in extensions
    instead of in chrome/browser.
    
    The missing dependencies triggered a lot of gn errors with a gn fixed
    to look at generated files (gn:57).
    
    The list is about 60 reports like:
    
    ERROR at //out/Default/gen/chrome/browser/extensions/api/generated_api_registration.cc:7:11: Include not allowed.
              ^--------------------------------------------------------------------------------
    It is not in any dependency of
      //chrome/browser/extensions/api:api_registration
    The include file is in the target(s):
      //chrome/browser/extensions:extensions
    which should somehow be reachable.
    
    Bug: 655123
    Change-Id: Ifc7809de17c9a426d2a6abdb41ecc42996b0d01f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1529095Reviewed-by: default avatarDevlin <rdevlin.cronin@chromium.org>
    Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
    Commit-Queue: Daniel Bratell <bratell@opera.com>
    Cr-Commit-Position: refs/heads/master@{#644715}
    6fec174a
BUILD.gn 240 KB