GitLab

This reverts commit 869062d9.

Reason for revert: Msan crashing due to uninitialized value:
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8911533900209194848/+/steps/browser_tests/0/logs/Deterministic_failure:_FeedbackTest.SubmissionTest__status_CRASH_/0

5:21315:0604/180329.553111:INFO:CONSOLE(193)] "Feedback: Sending report", source: chrome-extension://gfdkimpbcpahaombhbimeihdjnejgicl/js/feedback.js (193)
==21315==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0x565429d9374f in Value ./../../base/values.cc:197:7
    #1 0x565429d9374f in make_unique<base::Value, double &> ./../../buildtools/third_party/libc++/trunk/include/memory:3131:0
    #2 0x565429d9374f in base::Value::SetDoubleKey(base::BasicStringPiece<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, double) ./../../base/values.cc:435:0
    #3 0x565429afadea in base::HistogramBase::WriteJSON(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*, base::JSONVerbosityLevel) const ./../../base/metrics/histogram_base.cc:157:8
    #4 0x565429b2e4dc in base::StatisticsRecorder::ToJSON(base::JSONVerbosityLevel) ./../../base/metrics/statistics_recorder.cc:170:16
    #5 0x565422ce3e07 in extensions::FeedbackPrivateSendFeedbackFunction::OnAllLogsFetched(bool, bool, scoped_refptr<feedback::FeedbackData>) ./../../extensions/browser/api/feedback_private/feedback_private_api.cc:363:9


Original change's description:
> Add browsertest for complete process of sending feedback report
> 
> This adds a new browsertest which adds a hook into the feedback uploader
> to catch it right before it does the actual report upload. This ensures
> that clicking on the button to send a feedback report actually results
> in the report getting queued to be sent. This covers a regression case
> which is in crbug.com/954563.
> 
> Bug: 955039, 954563
> Test: Browser tests pass, fail if prior regression was put back
> Change-Id: I92762c1b6741ad057e78c8cafeb924f93995b249
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632534
> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com>
> Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#666036}

TBR=afakhry@chromium.org,jkardatzke@google.com

Change-Id: I004940a9156698865fddd6152e298c49797aa3bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 955039, 954563
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644855Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666178}