• bsheedy's avatar
    More clearly point out XR JavaScript failures · 703b5aa8
    bsheedy authored
    Makes the first (and thus fatal) failure from JavaScript more clear in
    the XR browser tests. This is achieved by adding logging to point the
    user towards the failure and stack that are actually useful for
    debugging.
    
    This is a workaround for a limitation of browser tests in general.
    FAIL() and other fatal macros provided by gtest only abort the current
    function. Since all the JavaScript execution is handled by helper
    functions, this means that even if we catch a failure in JavaScript and
    report it as a failure, the browser test will continue to run. This can
    then cause debugging issues because errors/stack traces from later on in
    the test end up getting printed as well since the test is continuing to
    run in a bad state.
    
    Bug: 961378
    Change-Id: Iafd4892dc7d5307fa35848a855d5f1c76bd27095
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605340
    Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
    Commit-Queue: Bill Orr <billorr@chromium.org>
    Reviewed-by: default avatarBill Orr <billorr@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#658773}
    703b5aa8
xr_browser_test.h 9.55 KB