• Etienne Bergeron's avatar
    Add a sanity check for detecting incorrect PreRunTestOnMainThread overloading · 70783602
    Etienne Bergeron authored
    This CL is adding a sanity dcheck to avoid tests crashing on MAC only when
    a chrome developer forgot to call the base function
    "ContentBrowserTest::PreRunTestOnMainThread".
    
    
      class MyBrowserTest : public ContentBrowserTest {
    
       public:
    
        void PreRunTestOnMainThread() override {
    
          [...]
    
          ContentBrowserTest::PreRunTestOnMainThread();
      // Required, otherwise crash on MAC.
        }
    
    I recently did that silly mistake and needed time to set up a MAC build to
    debug it. I believe this test is cheap enough and worth saving developers time.
    
    R=sky@chromium.org
    
    Change-Id: Iec0ed2e19b216a35c675016ad6ff88dc9e1c86ad
    Reviewed-on: https://chromium-review.googlesource.com/c/1407110Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#626186}
    70783602
content_browser_test.h 2.36 KB