-
Nick Diego Yamane authored
When a tab is dragged out of a maximized window, the detached window is created in restored state (ie: with different geometry) and tab drag controller needs to adjust the window and dragged tabs' bounds (more specifically x location), so that they appear under the pointer. That's done at TabStrip::TabDragContextImpl::SetBoundsForDrag() function [2], which calls into Views::SetBoundsRect() for each selected Tab view. It turns out that it is not enough to ensure the tabstrip and its parent, TabStripRegionView, get properly re-laid out, leading to issues like [1], where the dragged tab gets partially or totally occluded by the TabStripRegionView's child views. To fix it, this CL adds layout invalidation for tab strip just after setting bounds rect for each dragged tabs, ensuring both tab strip and its parent views are correctly relaid out. Bug: 1151092 [1] https://drive.google.com/file/d/1a6kEVy0DNUo9TTeiCYjkpf7d42TI3T7n [2] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/views/tabs/tab_strip.cc;l=697-708;drc=d81c5852498699fe3cd812e78d31c77c28e29281 R=sky@chromium.org Change-Id: I51244ad4485856334ce3443ed92ce80e2fad2cd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2572040 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#843781}
71263453