GitLab

Currently many tests check for kShelfScrollable and return early.
This causes missing regressions (such as crbug.com/1015688).

This CL removes early returns at the start of test methods and instead
force-disables force-disable kShelfScrollable (and also kShelfHotseat
which triggers kShelfScrollable) for these methods. This ensures that
these methods will be run even when kShelfScrollable and/or
kShelfHotseat are enabled by default.

A few tests remain that have a flag check in the middle of the test,
those are left unchanged. Replacing those will require extra work.

Bug: 1015891
Test: ash_unittests --enable-features=kShelfScrollable
Test: ash_unittests --disable-features=kShelfScrollable
Change-Id: Ic7a0987fbc4ffb8b68e262deb5830e832461583c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1868984Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#707808}