• Elly Fong-Jones's avatar
    views: split BubbleDialogDelegateView · 714a98f9
    Elly Fong-Jones authored
    This change moves most of the logic from BubbleDialogDelegateView into a
    new class, BubbleDialogDelegate. BubbleDialogDelegate implements the
    anchoring logic for bubbles, as well as some ancillary functionality
    around widget activity, anchor view highlighting, and so on.
    
    BubbleDialogDelegateView is now mostly a stub class that subclasses both
    BubbleDialogDelegate and View, and overrides some behavior of View.
    
    BDDV = BubbleDialogDelegateView
    BDD = BubbleDialogDelegate (doesn't yet exist)
    DDV = DialogDelegateView
    DD = DialogDelegate
    WD = WidgetDelegate
    V = View
    
    This CL is the second step in this process:
    
    1. BDDV inherits from DD & V (landed in r770128)
    2. Break BDDV into BDD (which inherits from DD) and BDDV (which
       inherits from both), like the current DD/DDV split
    3. For each client class that subclasses BDDV, move that class to
       subclassing View and containing a BDD member, which is used when
       a BDD, DD, or WD is needed.
    4. Delete BDDV itself
    5. Repeat (3) for DDV instead of BDDV
    6. Delete DDV itself
    7. Remove any remaining subclasses of BDD or DD
    
    Change-Id: Ie300eebdeab59709e2bb437ed8c26ee29d0c2835
    Bug: 1075649, 1011446
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209374
    Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
    Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
    Reviewed-by: default avatarScott Violet <sky@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#771905}
    714a98f9
focus_manager.cc 21.8 KB