GitLab

The fix to crbug.com/826701 resulted in crbug.com/827931 highlighting
that calling ShowProfileErrorDialog that early (before ResourceBundle
is initialized) is just not possible.

As discussed @ https://chromium-review.googlesource.com/c/chromium/src/+/985110/3/chrome/browser/prefs/chrome_pref_service_factory.cc#332
it is preferable to defer this message to BrowserThread::UI for when
it is brought up.

Turns out ChromeBrowserMainParts::DeferringTaskRunner already puts an
early ThreadTaskRunnerHandle in place for this very purpose :)

R=sky@chromium.org

Bug: 827931
Change-Id: Icf409103e51cf9957ac60b3ffa4b8310a5b36dbb
Reviewed-on: https://chromium-review.googlesource.com/996215Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548509}