• Mikel Astiz's avatar
    Avoid test dependency to SESSIONS SyncableService · 72bc0424
    Mikel Astiz authored
    These unit tests are the last examples of tests depending on
    implementation details of SESSIONS sync, where overriding a feature
    toggle was necessary.
    
    Instead, let's embrace the new USS implementation.
    
    Longer term, it may make sense to remove this dependency altogether and
    migrate these unit tests to a test-specific OpenTabsUIDelegate. For
    anything fancier, we should use proper sync integration tests. This
    intermediate step makes it more obvious that there aren't behavioral
    changes between the two sync implementations.
    
    Bug: 895455
    Change-Id: I1c3f26ec3037d71908cbf090644bf0580d8fd41b
    Reviewed-on: https://chromium-review.googlesource.com/c/1301435
    Commit-Queue: Peter Kasting <pkasting@chromium.org>
    Reviewed-by: default avatarPeter Kasting <pkasting@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#608641}
    72bc0424
session_sync_service.h 3.25 KB