-
yutak authored
Revert of cc: Plumb the monitor color profile to renderer for rasterization (patchset #6 id:100001 of https://codereview.chromium.org/2325773003/ ) Reason for revert: Suspected cause of the following MSAN failure. https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/12218 19:03:27.700 29717 ==4==WARNING: MemorySanitizer: use-of-uninitialized-value 19:03:27.700 29717 #0 0x7853dbe in computeTypeMask third_party/skia/src/core/SkMatrix44.cpp:59:23 19:03:27.700 29717 #1 0x7858825 in getType third_party/skia/include/core/SkMatrix44.h:208:31 19:03:27.700 29717 #2 0x7858825 in setConcat third_party/skia/src/core/SkMatrix44.cpp:378:0 19:03:27.700 29717 #3 0x76f8840 in operator*= ui/gfx/transform.h:253:5 19:03:27.700 29717 #4 0x76f8840 in ColorSpaceToColorSpaceTransform ui/gfx/color_transform.cc:563:0 19:03:27.700 29717 #5 0x76f78de in NewColorTransform ui/gfx/color_transform.cc:703:15 19:03:27.700 29717 #6 0x767f315 in GetColorSpace ui/gfx/icc_profile.cc:142:45 19:03:27.700 29717 #7 0xb2263ae in initializeLayerTreeView content/renderer/render_widget.cc:1141:61 19:03:27.700 29717 #8 0xb1e68fd in initializeLayerTreeView content/renderer/render_view_impl.cc:1956:17 19:03:27.700 29717 #9 0xc1c6b06 in initializeLayerTreeView third_party/WebKit/Source/web/WebViewImpl.cpp:4341:19 19:03:27.700 29717 #10 0xc1c57bf in WebViewImpl third_party/WebKit/Source/web/WebViewImpl.cpp:471:5 19:03:27.700 29717 #11 0xc1c29ff in create third_party/WebKit/Source/web/WebViewImpl.cpp:342:25 19:03:27.700 29717 #12 0xc1c29ff in create third_party/WebKit/Source/web/WebViewImpl.cpp:336:0 19:03:27.700 29717 #13 0xb19b457 in Initialize content/renderer/render_view_impl.cc:717:7 <snip> Original issue's description: > cc: Plumb the monitor color profile to renderer for rasterization > > This adds the output device color profile to display::Display, and > populates it correctly on Mac. We will want to do this for all > platforms. > > The color profile is then plumbed through the same IPCs that take > the device scale factor, to get to the renderer process' > RenderWidgetCompositor. > > Note that we are sending the full ICCProfile this far. This is > important, because the renderer process will be setting the ICCProfile > of its rasterized IOSurfaces, and there is a power impact of even slight > differences between the monitor profile and the IOSurface profile. > > The ICCProfile is then sent as a gfx::ColorProfile (which internally > references the ICCProfile, for the above purpose) to the > RenderWidgetCompositor, from where it will be pushed to cc. > > In the next step, we will (under a flag) specify the color space > for rasterization. > > BUG=44872 > CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel > > Committed: https://crrev.com/f1fef7489c29deeee2a29c41ce4851e9ad1bd67b > Cr-Commit-Position: refs/heads/master@{#418422} TBR=enne@chromium.org,clamy@chromium.org,dcheng@chromium.org,ellyjones@chromium.org,ccameron@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=44872 Review-Url: https://codereview.chromium.org/2336113003 Cr-Commit-Position: refs/heads/master@{#418490}
72cc58ad
