• Hitoshi Yoshida's avatar
    IDL compiler: Use inner type names for IDLUnion member accessors · 72f86a1d
    Hitoshi Yoshida authored
    Generally we use type names of each member as accessor names
    in generated union implementations.
    But for annotated types, the difference from its inner type is
    the conversion from V8 values to native values. i.e. NativeValueTraits.
    It means that their C++ accessors for each member work as same with
    their inner types' ones.
    And it is annoying to use annotated type's names for other objectives
    like IsLongClamp() and SetStringTreatNullAsEmptyString("foo").
    
    So this CL makes the generator to use inner type names in
    IDLUnion member accessors.
    It means we do not have to consider if a member has extended
    attributes or not, when we access the members.
    
    
    Bug: 894469
    Change-Id: I80a6ea2366405a7ae344d740e1611cea20b88d9e
    Reviewed-on: https://chromium-review.googlesource.com/c/1280382
    Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
    Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
    Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
    Reviewed-by: default avatarKenichi Ishibashi <bashi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#603047}
    72f86a1d
v8_union.py 6.73 KB