• Prashant Malani's avatar
    Revert "midi: Use std::deque for MidiMessageQueue" · 736c0dcd
    Prashant Malani authored
    This reverts commit c3311e2b.
    
    Reason for revert: Chromium OS can continue to use the std::deque version, since it checks out this directory at a specific commit. Chromium can revert to using the circular_deque variant.
    
    This means that there will be a transitional discrepancy between MidiMessageQueue implementations in Chromium and Chromium OS, but
    those should be resolved once libchrome in Chromium OS gets uprev-ed.
    
    BUG=chromium:787643
    TEST=None
    
    Original change's description:
    > midi: Use std::deque for MidiMessageQueue
    > 
    > For the purposes of this class, the semantics of circular_deque and
    > std::deque are the same. Switching to std::deque will make this class
    > easier to re-use outside of Chrome, by reducing its dependency on
    > src/base/containers.
    > 
    > BUG=chromium:701005
    > TEST=MIDI works on Chrome.
    > 
    > Change-Id: Iae83c69ef85682fbde75e6078cd5eb262b9f4082
    > Reviewed-on: https://chromium-review.googlesource.com/784010
    > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
    > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#518599}
    
    TBR=toyoshim@chromium.org,pmalani@google.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:701005
    Change-Id: Id061ff49297b1b40b3e0417ad3022e744a7c2fa6
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743035Reviewed-by: default avatarTakashi Toyoshima <toyoshim@chromium.org>
    Commit-Queue: Prashant Malani <pmalani@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#685239}
    736c0dcd
midi_message_queue.h 2.62 KB