• Maxim Kolosovskiy's avatar
    Reland "Reland "cros: Implement ClipboardImageModelFactory"" · 7387e33c
    Maxim Kolosovskiy authored
    This reverts commit 1d850b0b.
    
    Reason for revert: this CL didn't cause the problem. The root cause was a tricky infra problem. sorry for wrong revert.
    
    Original change's description:
    > Revert "Reland "cros: Implement ClipboardImageModelFactory""
    > 
    > This reverts commit 57af2c42.
    > 
    > Reason for revert: No good reason, but this build causes a compilation error. No clear culprit. https://ci.chromium.org/p/chromium/builders/ci/Mac%20ASan%2064%20Builder/104190
    > 
    > Original change's description:
    > > Reland "cros: Implement ClipboardImageModelFactory"
    > > 
    > > This reverts commit 5822a03a.
    > > 
    > > Reason for revert:
    > > It turned out that the test is flaky regardless of this change.
    > > Probably this just made it easier to reproduce the flakiness.
    > > 
    > > Original change's description:
    > > > Revert "cros: Implement ClipboardImageModelFactory"
    > > > 
    > > > This reverts commit 056d2885.
    > > > 
    > > > Reason for revert:
    > > > This is a speculative revert for failures on 
    > > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38382
    > > > 
    > > > This could fail the following test:
    > > > ClipboardHistoryWithMultiProfileBrowserTest.ShouldPasteHistoryAsPlainText
    > > > 
    > > > Original change's description:
    > > > > cros: Implement ClipboardImageModelFactory
    > > > > 
    > > > > Implements ClipboardImageModelFactoryImpl.
    > > > > Previous CL landed ClipboardImageModelFactory, and all
    > > > > ash-side usages of the factory.
    > > > > 
    > > > > This CL implements rendering of HTML via
    > > > > ClipboardImageModelRequest.
    > > > > 
    > > > > Bug: 1117230
    > > > > Change-Id: I2f7ac67eadac5ef1a3c7cfca9918de438f02ff8e
    > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367395
    > > > > Commit-Queue: Alex Newcomer <newcomer@chromium.org>
    > > > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
    > > > > Auto-Submit: Alex Newcomer <newcomer@chromium.org>
    > > > > Cr-Commit-Position: refs/heads/master@{#802779}
    > > > 
    > > > TBR=xiyuan@chromium.org,newcomer@chromium.org
    > > > 
    > > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > > > 
    > > > Bug: 1117230
    > > > Change-Id: Ibc178e2d0b50bb423bc5a128aead30a5f471bd18
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383532
    > > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    > > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#803003}
    > > 
    > > TBR=xiyuan@chromium.org,nhiroki@chromium.org,newcomer@chromium.org
    > > 
    > > # Not skipping CQ checks because this is a reland.
    > > 
    > > Bug: 1117230
    > > Change-Id: I49fe530783a23a65e06456ca3c4ab3703dde35e2
    > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384712
    > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
    > > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#803027}
    > 
    > TBR=xiyuan@chromium.org,nhiroki@chromium.org,newcomer@chromium.org
    > 
    > Change-Id: Iad7614b249091bfcce8a27f10ae4e67de86a2a29
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: 1117230
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382603
    > Reviewed-by: Maxim Kolosovskiy  <kolos@chromium.org>
    > Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#803043}
    
    TBR=xiyuan@chromium.org,nhiroki@chromium.org,kolos@chromium.org,newcomer@chromium.org
    
    # Not skipping CQ checks because this is a reland.
    
    Bug: 1117230
    Change-Id: I410473bc38efce068f1c3d2a2158489ff4eb4f17
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382122Reviewed-by: default avatarMaxim Kolosovskiy  <kolos@chromium.org>
    Commit-Queue: Maxim Kolosovskiy  <kolos@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#803080}
    7387e33c
clipboard_image_model_factory.h 2.08 KB