-
Trent Apted authored
This reverts commit 58ab87ff. Reason for revert: suspected for lsan browser_tests and mus_browser_tests failures since https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/25937 - AppBannerManagerBrowserTest.CheckOnLoadWithSufficientEngagementCancelBannerAfterPromptInHandler - AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerReprompt - AppBannerManagerBrowserTest.ExperimentalFlowWebAppBannerPromptNeedsGesture (and others in later runs)> Possibly timeout related. Original change's description: > Consolidate app banner testing. > > This CL removes several different app banner testing files, and replaces > them by calling the necessary JavaScript setup code in one test file. > For instance, all tests will no longer have the "appinstalled" title > overwriting, as that will only be active when the appropriate setup > JavaScript is run. > > This allows future tests to be more easily added, and reduces collisions > when manipulating the page title. > > BUG=806923 > > Change-Id: Ia28837b8675a2e1fe329cb1df1be4798ddb03d02 > Reviewed-on: https://chromium-review.googlesource.com/892182 > Commit-Queue: Dominick Ng <dominickn@chromium.org> > Reviewed-by: Matt Giuca <mgiuca@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532978} TBR=mgiuca@chromium.org,dominickn@chromium.org Change-Id: Ie030290324c689b3df616de9aa35b6e52e7584c5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 806923 Reviewed-on: https://chromium-review.googlesource.com/895024Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#533178}
744fd440