• Jesse McKenna's avatar
    Replace --single-argument= with --single-argument · 74ae85ac
    Jesse McKenna authored
    This change changes the command-line single-argument switch, used for
    launches from the Windows shell, from `--single-argument=` to
    `--single-argument `. This fixes an issue where users who have updated
    but not restarted Chrome are unable to open shell links (due to the
    mismatch between the just-updated open command in the registry and the
    expectations of the now-obsolete running browser).
    
    crrev.com/c/21165961 changed the command line used by the Windows shell
    (and set in the registry) from `"chrome.exe" "%1"` (where %1 is
    replaced by the argument to launch by the shell) to
    `"chrome.exe" --single-argument=%1` to enforce a limit of one
    argument on shell-based launches.
    
    This caused old versions (those which have updated but not restarted
    Chrome) to receive `--single-argument=<arg>` when Chrome is invoked
    from the shell, but be unable to interpret it. Because this change
    replaces the `=` with ` `, it is more backwards-compatible with old
    versions. They will simply ignore the `--single-argument` switch and
    interpret the space-delimited <arg> as the argument until the user
    restarts Chrome to launch the new version.
    
    Bug: 1092913
    Change-Id: Iba734fe290944176f7ad38d36e670a1bea04623b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238270Reviewed-by: default avatarLei Zhang <thestig@chromium.org>
    Reviewed-by: default avatarGreg Thompson <grt@chromium.org>
    Commit-Queue: Jesse McKenna <jessemckenna@google.com>
    Cr-Commit-Position: refs/heads/master@{#778584}
    74ae85ac
shell_util_unittest.cc 45.1 KB