• Gauthier Ambard's avatar
    Revert "[iOS][Thumb Strip] Keep BVC's position fixed when switching to Incognito" · 75b464e6
    Gauthier Ambard authored
    This reverts commit 99a42e2d.
    
    Reason for revert: Potential culprit for crbug.com/1152712, reverting to check the bot.
    
    Original change's description:
    > [iOS][Thumb Strip] Keep BVC's position fixed when switching to Incognito
    >
    > Before, when switching to incognito using the Thumb Strip, the BVC ended
    > up having a frame.y = 36 (or some other non-zero constant). It looks
    > like the BVC is currently positioned by frame, and my guess is that
    > somehow, the position of some other element + constraints caused the
    > BVC's frame to change after it was set. However, the BVC's frame could
    > be set by constraint, as it should always be that value.
    >
    > Bug: 1094335
    > Change-Id: Iedeedadf7ac7c7e842ebe4af02d8e62ed3b6a7c8
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549947
    > Commit-Queue: Robbie Gibson <rkgibson@google.com>
    > Reviewed-by: Mark Cogan <marq@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#830146}
    
    TBR=marq@chromium.org,rkgibson@google.com
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 1094335
    Change-Id: I6fd0c59f79f9ac8bbc3cad70476ca3327b0c02e5
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560116Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
    Reviewed-by: default avatarMark Cogan <marq@chromium.org>
    Commit-Queue: Gauthier Ambard <gambard@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#830968}
    75b464e6
BUILD.gn 8.44 KB