• Min Qin's avatar
    Fix an issue that incognito download may use the same id as regular download · 75d9ad10
    Min Qin authored
    As we moved the download id generation logic to DownloadManagerImpl, but
    incognito download is still using regular profile's DownloadManagerDelegate
    to generate the id. So it is possible that incognito download may have the
    same id as a regular download.
    In theory this shouldn't be an issue as incognito and regular download belongs
    to different DownloadManagerImpl. However, Chrome's download home and extensions
    use id to uniquely identify a download. Thus causing the issues when accessing
    these downloads from the download home and extensions.
    
    BUG=902336
    
    Change-Id: I3591153e4f453c75d4877f5ce1088c096d3edf1e
    Reviewed-on: https://chromium-review.googlesource.com/c/1330214Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
    Reviewed-by: default avatarXing Liu <xingliu@chromium.org>
    Commit-Queue: Min Qin <qinmin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#607059}
    75d9ad10
mock_download_manager.h 6.56 KB