• Lei Zhang's avatar
    Avoid confusion with PaymentRequestUnitTestBase. · 76f62502
    Lei Zhang authored
    PaymentRequestUnitTestBase is not a test class, yet it looks like one
    since it has SetUp() and TearDown(). To make it more obvious that it is
    not a test class:
    
    1) Prefix SetUp() and TearDown() with "Do".
    2) Label the SetUp() and TearDown() overrides in classes that inherit
       from PaymentRequestUnitTestBase. Typically the methods override
       PlatformTest.
    
    Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
    Change-Id: I5c43bd5bf5adee7acd93e40f9a403a90a95180ae
    Reviewed-on: https://chromium-review.googlesource.com/c/1281238
    Commit-Queue: Lei Zhang <thestig@chromium.org>
    Reviewed-by: default avatarMoe Ahmadi <mahmadi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#599779}
    76f62502
payment_request_unittest_base.mm 2.13 KB