GitLab

Adapts NetworkContextTest.NotifyExternalCacheHit to enforce its
assumption that the split cache is not enabled. Adds a DCHECK to
GenerateCacheKey, ensuring that the NetworkIsolationKey (NIK) is present
if the split cache is enabled (its absence had caused the test to fail).
This DCHECK is hit by many tests when the split cache is enabled. We fix
the URLLoaderTest.* and SimpleURLLoaderTest.* tests. Other tests will be
fixed in future CLs.

Bug: 1009595
Change-Id: Icf24ad810be6b8adbb179837020ac3520505dfb5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1837235Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Eric Orth <ericorth@chromium.org>
Commit-Queue: Alex Turner <alexmt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705336}