• Nick Diego Yamane's avatar
    ozone: Fix regression in key events translation · 7758f33b
    Nick Diego Yamane authored
    Such regression had already been fixed by crrev.com/c/1823795 but has
    been re-introduced by crrev.com/c/1866752. So, in this CL a fix similar
    to crrev.com/c/1823795 is applied new XEvent => ui::Event translation
    code with a difference, generalize it to any ozone platform, instead of
    only OS_CHROMEOS as in the original patch.
    
    Context:
    
    X11EventSource is used by both non-Ozone and Ozone X11, which have
    different keyboard layout management implementations. Non-ozone
    currently (more specifically after crrev.com/c/1813417) assumes
    DomKey/DomCode are set at KeyEvent construction, while Ozone handles it
    lazily in KeyEvent::ApplyLayout(). So, this change in XEvent =>
    ui::Event translation code is needed to properly support these 2
    different code paths.
    
    Bug: 1007389
    Change-Id: I7bab6f0187cefdad36ef9246766cd64464dc8b49
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895399Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
    Commit-Queue: Nick Yamane <nickdiego@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#713035}
    7758f33b
BUILD.gn 19.9 KB