• Ben Wells's avatar
    Revert "Test any widget activated in a browser test for accessibility violations" · 777cefdf
    Ben Wells authored
    This reverts commit 0a869fb4.
    
    Reason for revert: New checker is causing errors on bot 
    e.g. https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/26753
    
    from the failure: The following view violates DoesViewHaveAccessibilityErrors():
    browser/ui/views/frame/BrowserRootView > ui/views/window/NonClientView > BrowserView > TopContainerView > ToolbarView > View > MenuButton (id 1008)
    - Focusable View has no accessible name or placeholder, and the name attribute does not use kAttributeExplicitlyEmpty.
    
    Original change's description:
    > Test any widget activated in a browser test for accessibility violations
    > 
    > Use ChromeViewsDelegate/WidgetObserver combination to ensure that all
    > widgets are tested for accessibility as they become hidden or visible
    > in a browsertest.
    > 
    > The test goes through the View entire subtree and ensure any focusable
    > View has an accessible name.
    > 
    > Bug: 819350
    > Change-Id: I213e02bcfb1ec64aefc528cbda6a8a2a1d7bd0d0
    > Reviewed-on: https://chromium-review.googlesource.com/951933
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Reviewed-by: Trent Apted <tapted@chromium.org>
    > Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#545904}
    
    TBR=sky@chromium.org,tapted@chromium.org,aleventhal@chromium.org
    
    Change-Id: I4acc057b19df35a9350ae04efa06e5f6b69b2e88
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: 819350
    Reviewed-on: https://chromium-review.googlesource.com/981634Reviewed-by: default avatarBen Wells <benwells@chromium.org>
    Commit-Queue: Ben Wells <benwells@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#546020}
    777cefdf
BUILD.gn 280 KB