• Bence Béky's avatar
    Do not use CompletionCallback in HttpCache::PendingOp. · 77a712db
    Bence Béky authored
    This is a lot of work just to avoid using CompletionCallback in
    HttpCache::PendingOp.  Of course one could have used
    CompletionRepeatingCallback instead, but that is not idiomatic, since
    the callback is only meant to be called once.  No functional change is
    intended.
    
    I wonder why PendingOps cannot be deleted in HttpCache destructor.
    I guess Backend or WorkItem must outlive HttpCache for whatever reason.
    I decided it is better not to introduce functional change here.
    
    Bug: 807724
    Change-Id: Idd7e304702ff31de11073c0a77d041f678fb6ae4
    Reviewed-on: https://chromium-review.googlesource.com/1161971
    Commit-Queue: Bence Béky <bnc@chromium.org>
    Reviewed-by: default avatarJosh Karlin <jkarlin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#580986}
    77a712db
http_cache.cc 47.7 KB