• Eric Karl's avatar
    Null DisplaySchedulerClient before teardown · 7888a399
    Eric Karl authored
    Currently, when Display is destroyed, it tears down DisplayScheduler
    midway through destruction. This is problematic as DisplayScheduler
    can call back into Display in a partially destroyed state.
    
    We could force DisplayScheduler to be destroyed earlier, but this
    is still somewhat brittle. Instead we allow DisplayScheduler to have
    a null DisplaySchedulerClient and null this before destroying
    Display.
    
    Bug: 1012943
    Change-Id: I5892ed2746ba29ef5c3c027e9564e52ee6c659ec
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863674
    Auto-Submit: Eric Karl <ericrk@chromium.org>
    Reviewed-by: default avatarKhushal <khushalsagar@chromium.org>
    Commit-Queue: Eric Karl <ericrk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#706492}
    7888a399
display.cc 39.3 KB