• Tetsui Ohkubo's avatar
    Revert "Implement ArcImeService::EnsureCaretNotInRect." · 78c473c9
    Tetsui Ohkubo authored
    This reverts commit 10fa9630.
    
    Reason for revert: Split view regression http://b/138674508
    
    Original change's description:
    > Implement ArcImeService::EnsureCaretNotInRect.
    > 
    > It's left as unimplemented because Android WM handles insets by VK for
    > most cases.
    > However, Android WM can't move the SystemTray up for inline-reply in an
    > Android notification because from Android WM's point of view,
    > notificaiton is placed at (0, 0).
    > This CL implements ArcImeService::EnsureCaretNotInRect to cover that
    > case.
    > This CL changes the behavior of windowed Android app with a11y keyboard.
    > Before this CL, a position of a window is not changed by a11y keyboard
    > visibility, but after this CL a position can be changed not to be
    > covered by a11y keyboard.
    > 
    >       SystemTray moves up if there is a space for it.
    > 
    > Bug: b/114115612
    > Test: manual - Focus on inline reply of an Android notificatioln and
    > Change-Id: Ib666b6c269a8fc36195d30affa4c7a8a805560d7
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631859
    > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
    > Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
    > Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#664583}
    
    TBR=sadrul@chromium.org,yhanada@chromium.org,tetsui@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    BUG=b:114115612
    BUG=b:138674508
    
    Change-Id: Ic614e72899dbd9efb7317bdecd33f540e5b85452
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777461Reviewed-by: default avatarTetsui Ohkubo <tetsui@chromium.org>
    Reviewed-by: default avatarYuichiro Hanada <yhanada@chromium.org>
    Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#692390}
    78c473c9
arc_ime_service.cc 21.2 KB