• Alan Cutter's avatar
    desktop-pwas: Treat icon processing the same for sync install as regular install · 78d64d86
    Alan Cutter authored
    This CL removes some icon processing logic that we do differently for
    sync initiated installs as they are unnecessary and contains the source
    of a DCHECK failure.
    
    We were DCHECK failing sync installation for sites that included icons
    with no size specified because we were storing this as size 0. During
    sync installation we would include this size 0 as part of the icons to
    generate. This produced an invalid icon that failed the DCHECK in
    ConvertWebAppToExtension() and caused the app sync install to fail
    entirely.
    
    Bug: 1062921
    Change-Id: I273276b63ba762d522b86423cc6aaf67740a871b
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120081
    Commit-Queue: Alan Cutter <alancutter@chromium.org>
    Reviewed-by: default avatarAlexey Baskakov <loyso@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#754737}
    78d64d86
favicon_only.html 155 Bytes