• Nektarios Paisios's avatar
    Cleanup: Modernizes some parts of CrossPlatformAccessibilityBrowserTest,... · 78f19056
    Nektarios Paisios authored
    Cleanup: Modernizes some parts of CrossPlatformAccessibilityBrowserTest, enables all disabled tests and makes them more consistent with other accessibility browser tests
    
    Some tests having to do with iframe traversal in CrossPlatformAccessibilityBrowserTest were disabled.
    In https://crrev.com/c/2556452, the kPDFRoot role is being added and the kWebArea role is being removed.
    Iframe traversal tests should be enabled and functioning to ensure the robustness of any code changes
    in those roles, as they could potentially break iframe navigation.
    
    Meanwhile, many of the code convensions used in CrossPlatformAccessibilityBrowserTest were different from all other accessibility browser tests
    and some have been superceded by changes to C++.
    
    This patch switches to using raw literal strings for loading HTML snippets, improves indentation, and
    uses the same method names for loading test pages as in other accessibility browser tests.
    Also, useless comments were eliminated and test fixtures cleaned up were necessary.
    
    Originally split out from
    https://crrev.com/c/2556452
    
    AX-Relnotes: n/a.
    
    R=dmazzoni@chromium.org, aleventhal@chromium.org
    
    Change-Id: Ia9c3094606581468d7f1b5c8849bb44668b47de1
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575101
    Commit-Queue: Nektarios Paisios <nektar@chromium.org>
    Auto-Submit: Nektarios Paisios <nektar@chromium.org>
    Reviewed-by: default avatarAbigail Klein <abigailbklein@google.com>
    Cr-Commit-Position: refs/heads/master@{#836225}
    78f19056
cross_platform_accessibility_browsertest.cc 66.1 KB