• Richard Knoll's avatar
    MessageCenter: Fix crash on reentrant RemoveAll · 7a0823a7
    Richard Knoll authored
    If a NotificationDelegate calls RemoveNotification in the Close handler
    we're trying to close it twice if the user clicks the "Close all" button
    in the message center. Instead remove the Notification from the list
    before calling Close so the next call exits early and is a noop as
    expected.
    
    This was fixed for RemoveNotification before in crrev.com/c/2330019 and
    this CL implements the same fix for RemoveAllNotifications.
    
    Bug: 1135709
    Change-Id: I27e365957554c56a6cbea0200c408c6706189f9f
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461119
    Commit-Queue: Richard Knoll <knollr@chromium.org>
    Reviewed-by: default avatarPeter Beverloo <peter@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#815592}
    7a0823a7
message_center_impl_unittest.cc 53 KB