• Mikel Astiz's avatar
    Revert "Enforce lower-case use of GUIDs for sync" · 7a6d0761
    Mikel Astiz authored
    This reverts commit b6a3c9f3.
    
    Reason for revert: bookmarks created around 2016, between [M44..M51]
    use an uppercase GUID as originator client item ID.
    
    Original change's description:
    > Enforce lower-case use of GUIDs for sync
    > 
    > base::GenerateGUID() produces lower-case GUIDs and they should get
    > exposed to the sync protocol exclusively in this canonical form to avoid
    > running into issues.
    > 
    > This patch replaces all occurrences in sync codebase with:
    > git grep -l 'IsValidGUID' -- components/sync* | \
    >   xargs sed -i 's/IsValidGUID/IsValidGUIDOutputString/g'
    > 
    > In addition, the implicit GUIDs used for bookmark sync, in particular
    > for permanent nodes, are updated to adopt lower-case GUIDs. These are
    > never committed to the server so there are no backward-compatibility
    > considerations.
    > 
    > Change-Id: I0d0468f3475e1a27a161e2af15853c757f53e201
    > Bug: 978430
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054154
    > Reviewed-by: Marc Treib <treib@chromium.org>
    > Reviewed-by: Scott Violet <sky@chromium.org>
    > Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#741381}
    
    TBR=sky@chromium.org,treib@chromium.org,mastiz@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: 978430
    Change-Id: If3a135e24cb61d15cfc7616dd1160e76ce9dd3e3
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2061749Reviewed-by: default avatarMikel Astiz <mastiz@chromium.org>
    Commit-Queue: Mikel Astiz <mastiz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#742118}
    7a6d0761
bookmark_specifics_conversions.cc 14.6 KB